Alter default behavior to non-persistent partition #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behavior uses electron default, which creates a partition for storage which persists between instances. This makes sense for electron but not necessarily for primary use cases of Nightmare. This change sets the default partition to be a non-persistent partition but allows a user to opt back into persistence with simple configuration options. Fixes segment-boneyard#916
|
More as a reminder to self when I pull this in: A note will need to be added to the release notes as a possibly breaking change. It's possible some folks out there are depending on this side effect, and it's probably worth mentioning. Otherwise, looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior uses electron default, which creates a partition
for storage which persists between instances. This makes sense for
electron but not necessarily for primary use cases of Nightmare.
This change sets the default partition to be a non-persistent partition
but allows a user to opt back into persistence with simple configuration options.
Fixes #916
4 new passing tests, all others green
Preview of wiki changes